Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work with angular-cli #1

Closed
ericel opened this issue Jan 27, 2018 · 9 comments
Closed

Doesn't seem to work with angular-cli #1

ericel opened this issue Jan 27, 2018 · 9 comments
Labels
enhancement New feature or request

Comments

@ericel
Copy link

ericel commented Jan 27, 2018

No errors with log, the behavior wasn't there. Does cli needs additional setup?

@pette9
Copy link

pette9 commented Jan 27, 2018

I have the same behaviour but the problem seems to be imagesloaded firing early when in production. The layouts without images work fine with the latest angular-cli

@ericel
Copy link
Author

ericel commented Jan 28, 2018

In my case i think it has something to do with Material2 mat-drawer-content

@Shailu4u
Copy link
Owner

@pette9 Can you please elaborate if there are any errors.

@pette9
Copy link

pette9 commented Jan 29, 2018

@Shailu4u There are no errors when I build for production with angular-cli "1.6.5" but when in production, The ImagesLoaded console log appears way before the images are loaded and the behaviour that follows is similar to what I get when I remove [useImagesLoaded]="true" or set [useImagesLoaded]="false" in development. For a masonry grid with no images, or few thumb sized images, it works fine for both development and production modes.

@ericel
Copy link
Author

ericel commented Jan 29, 2018

@Shailu4u is there a way to call the reloadItems from the service. I checked the service I didn't see any such method. It would be nice especially as when I delete an item as for now , the layout breaks. So It would be nice to call reload layout on item delete complete.

@Shailu4u Shailu4u added the enhancement New feature or request label Jan 30, 2018
@Shailu4u Shailu4u reopened this Jan 30, 2018
@Shailu4u
Copy link
Owner

Shailu4u commented Feb 1, 2018

@ericel @pette9 Updated the library with new version @1.2.0.
New features implemented such Add, Append, Prepend, RemoveItem, RemoveFirstItem and RemoveAllItems, onNgMasonryInit event.

@Shailu4u
Copy link
Owner

Shailu4u commented Feb 1, 2018

@pette9 Fixed all bugs related to imagesLoaded etc.

@Shailu4u
Copy link
Owner

Shailu4u commented Feb 1, 2018

@ericel Now we can get Masonry instance using onNgMasonryInit event. We can use all available Masonry methods with that instance such as reloadItems(), layout() etc

@Shailu4u
Copy link
Owner

Shailu4u commented Feb 6, 2018

Updated the package with all fixes. Hence closing the issue.

@Shailu4u Shailu4u closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants