New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Die to Make external Thread #64
Comments
Interesting idea. I'm rather busy now, but I will add to the "todo" list. |
OK I gave it a shot: While I was at it, I also added a threaded rod object. If are using some standard threaded rod in a project, you can skip modelling a shaft and using the die object on it. I was pleasantly surprised to see that the screw maker macro actually models a specifically inner diameter style thread when the tap tool is used. I left this functionality unchanged. Both the die and threaded rod objects use the proper OD threads. Some new and updated icons: My fork with the changes: Other things to note: Check it out and tell me what you think! |
Hi Alex, what you describe is what I meant, that looks great, thank you for taking the time. How can I use what you have done though? ie I take it at the moment I can't just update the WB through Add-on Manager within FreeCAD. |
I have added a pull request for the changes. If/when it gets accepted, you will be able to use the new features through the addon manager. If you are feeling impatient, you can download https://github.com/slowinternets/FreeCAD_FastenersWB as a zip file, and copy its contents into the correct directory. |
@slowinternets , |
@slowinternets , Thank you again. |
@slowinternets, Thought I try and install and give it a spin, its great. But I just realised though when I went to use it that the icon and description don't match the function. ie The 'ScrewTap' tool icon creates a external thread, where a Tap should create a inner thread. I'm not sure the Tap function is working as expected (with ignoring the icons being dis-orientated) . For instance it seems to just create a rod with a inner thread, not actually cut a inner thread on a solid cylinder for instance. Sorry I'm greatly appreciative, just trying to add input. |
@ slowinternets , Thank you for the explanation I now understand that it is actually creating the 'tool' as such and than need to make a boolean cut to get the desired result. Yes it didn't seem intuitive to me to work that way. I was expecting to select circular edge of a cylinder then select the Die tool and have it 'cut the thread' resulting in a external thread. |
The new tools have been merged into the main branch, and are now available through the addon manager. It would certainly be very cool to be able to go directly from a selected edge or face to a threaded part. However, that would be a much larger and more complicated feature to implement. For now, there are other things that I would like to add to the workbench first. If you are happy with the state of these tools at the moment, please consider closing this issue. |
Very nice tool, thanks so much! I have worked with it and have found a bug when working with more complex examples. I do not know if the bug is from FreeCAD directly, or something in this workbench? See https://forum.freecadweb.org/viewtopic.php?f=3&t=48241&p=412994 |
Ok apparently, it was due to a 'coplanar issue'. |
What's left regarding the FR ? |
@alexneufeld Wonderful addition to the workbench, thank you! Would it be difficult to add imperial or custom diameter and pitch sizes for the tap and die tools? I'm not familiar with how plugins are written but I'll jump in if someone here isn't able to figure it out easily. |
Yeah, I could do that. Busy at the moment, give me a few days to throw a PR together |
Can we close this ticket? |
|
Closing this issue as complete |
@shaise reminder to close this issue |
Would it be possible to add a 'die' tool/feature that allow the making of a external thread on a existing shaft, also with a selection of thread length?
The text was updated successfully, but these errors were encountered: