Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XML escape package description #3

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

mwegrzynek
Copy link
Contributor

Packages with characters not legal in XML (for example &) in package description are rejected by Cholatey client, with malformed XML message. This pull request fixes that.

@google-cla
Copy link

google-cla bot commented Oct 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joeyparrish joeyparrish changed the title XML escape package description fix: XML escape package description Oct 3, 2023
@joeyparrish
Copy link
Member

@mwegrzynek, thank you for the fix! There are two issues that we need to resolve:

  1. You need to sign the Contributor License Agreement (see the bot comment above). This is Google bureaucracy, and I can't do anything about it.
  2. You need to add xml-escape to the dependencies with npm install xml-escape and then add package.json and package-lock.json to your PR.

Thanks!

@mwegrzynek
Copy link
Contributor Author

Done!

@joeyparrish joeyparrish merged commit 71068d4 into shaka-project:main Oct 4, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 4, 2023
@joeyparrish
Copy link
Member

Published to NPM. Thanks for contributing!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants