Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Indexing bytes produces int on python3 for pssh-box.py #1228

Merged
merged 1 commit into from Jul 12, 2023

Conversation

allanlei
Copy link
Contributor

@allanlei allanlei commented Jul 8, 2023

Fixes #1227

@allanlei allanlei changed the title Fix: Indexing bytes produces int on python3 Fix: Indexing bytes produces int on python3 for pssh-box.py Jul 8, 2023
@allanlei allanlei changed the title Fix: Indexing bytes produces int on python3 for pssh-box.py fix: Indexing bytes produces int on python3 for pssh-box.py Jul 8, 2023
@joeyparrish
Copy link
Member

Thank you for contributing! If the build & tests pass, I'll merge this.

@joeyparrish
Copy link
Member

I believe the test failures on Linux are those fixed by #1226, and the Windows and Mac failures are aging build systems and scripts which are all being replaced in the cmake branch. Merging as-is.

@joeyparrish joeyparrish merged commit d9d3c7f into shaka-project:main Jul 12, 2023
3 of 22 checks passed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pssh-box.py parsing is not compatible with python3
2 participants