fix: Fix tags in official Docker images and binaries #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release workflows did not run checkout with fetch-tags: true, so the builds were unable to compute the correct release version number. I audited all instanced of actions/checkout to add fetch-tags where needed and clean up unneeded options. Closes shaka-project#1366
|
See the fix at work here: $ docker run joeyparrish/shaka-packager-staging:v3.0.4 packager --version
packager version v3.0.4-f52052a-debug |
cosmin
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflows did not run checkout with
fetch-tags: true, so the builds were unable to compute the correct release version number. I audited all instances ofactions/checkoutto addfetch-tagswhere needed and clean up unneeded options.I also had to fix options to
docker/build-push-action, which by default ignoresactions/checkoutand tries to pull from git itself. This led to the Docker build running in a context without the new tag.Finally, to make verification easier and provide version info in the build logs, this adds debugging info to the version-generation script via stderr.
Closes #1366