Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch errors from loading the library #7

Closed
theodab opened this issue Nov 15, 2018 · 0 comments
Closed

Catch errors from loading the library #7

theodab opened this issue Nov 15, 2018 · 0 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.0

Comments

@theodab
Copy link
Collaborator

theodab commented Nov 15, 2018

When initially loading the library, the error catching callback has not yet been set by the user. Because of that, any errors that are thrown at that time aren't passed on to the user. This can be reproduced by adding a typo into shaka-player.compiled.js or shaka-player.compiled.debug.js.
@theodab theodab added the type: bug Something isn't working correctly label Nov 15, 2018
@TheModMaker TheModMaker added this to the v1.0 milestone Sep 26, 2019
@TheModMaker TheModMaker self-assigned this Sep 27, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 28, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
3 participants
@TheModMaker @shaka-bot @theodab