Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPD@availabilityStartTime of 0 incorrectly triggers assertion about not having AST #1147

Closed
sandersaares opened this issue Nov 22, 2017 · 2 comments
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue

Comments

@sandersaares
Copy link
Contributor

sandersaares commented Nov 22, 2017

Have you read the FAQ and checked for duplicate issues:
yes

What version of Shaka Player are you using:
2.2.6-debug

Can you reproduce the issue with our latest release version:
unknown, used demo app

Can you reproduce the issue with the latest code from master:
unknown, used demo app

Are you using the demo app or your own custom app:
demo app

If custom app, can you reproduce the issue using our demo app:
N/A

What browser and OS are you using:
Chrome 62, Windows 10

What are the manifest and license server URIs:
https://media.axprod.net/PublicVideos/DashAstZero/Manifest.mpd

No segments are publically available - manifest only. Should be enough to reproduce.

What did you do?
Hit Load to start playback.

What did you expect to happen?
Player attempts to play back live presentation, no errors reported.

What actually happened?
Assertion failed: Detected as IPR stream, but does not match our model of IPR!

This appears to be because MPD@availabilityStartTime is "1970-01-01T00:00:00Z" which gets parsed to 0 in dash_parser.js. Because of that the presentationStartTime_ check in the below assertion from presentation_timeline.js fails (0 == null).

      goog.asserts.assert(this.presentationStartTime_ != null &&
                          this.segmentAvailabilityDuration_ == Infinity,
          'Detected as IPR stream, but does not match our model of IPR!');
@TheModMaker
Copy link
Contributor

Duplicate of #1148

0 != null, the problem is that segmentAvailabilityDuration_ is not infinity. This is the same problem as your other manifest, your live streams have a duration. We'll continue the discussion there.

@TheModMaker TheModMaker added the status: duplicate A duplicate of another issue; should be closed after linking to the original issue label Nov 22, 2017
@sandersaares
Copy link
Contributor Author

I confirm your assessment of the facts. Apologies for insufficient investigation on my side!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue
Projects
None yet
Development

No branches or pull requests

3 participants