Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend allowing the license server be configurable. #135

Closed
chemoish opened this issue Jul 23, 2015 · 1 comment
Closed

Recommend allowing the license server be configurable. #135

chemoish opened this issue Jul 23, 2015 · 1 comment
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@chemoish
Copy link

The license_server I am using consists of the following format…

www.example.com
&token={{token}}
&account={{account}}
&_releasePid={{releasePid}}
&_widevineChallenge={{widevineChallenge}}

I am able to construct everything beyond the widevineChallenge before instantiating shaka.player.DrmSchemeInfo.

I need to be able to append the widevineChallenge to the license server before the request gets sent by shaka.util.LicenseRequest.send().

var license_server = ...

return new shaka.player.DrmSchemeInfo(
    'com.widevine.alpha',
    license_server,
    false, /* withCredentials */
    null, /* licensePostProcessor */
    licensePreProcessor /* licensePreProcessor */
);

function licensePreProcessor(license_request_info) {
    // modify license server somehow
}

Currently the license_request_info has body and headers (https://github.com/google/shaka-player/blob/master/lib/player/drm_scheme_info.js#L142).

  • Possibly add a way to pass query string parameters?
  • Possible add a way to manipulate the license server beyond string manipulation?
@tdrews tdrews added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors labels Jul 23, 2015
@tdrews tdrews self-assigned this Jul 23, 2015
@tdrews
Copy link
Contributor

tdrews commented Jul 23, 2015

We can add a licenseServerUrl override to the licenseRequestInfo object.

@tdrews tdrews closed this as completed in 8880a8e Jul 27, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants