-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event for RECOVERABLE networking errors and subsequent retries #1529
Comments
@theodab I don't mind sending in a PR if we agree on a design. |
@chrisfillmore Your design seems reasonable to me, but I should probably do it. @vaage is currently working on #1297, so it'd be best to do this in-house, to avoid collisions. |
I had a discussion with the team, and we decided that it would probably be best to avoid anything that changes the constructor of NetworkingEngine, since it is also being modified as part of #1051. Instead, I will add a method on the networking engine that adds a listener function. So you'd use it like:
|
Sounds good, thank you! |
Okay, after another round of code review, this should be out soon.
Sorry we changed our minds so often on this! |
Thanks, @theodab! |
We would like to know when a networking error occurs which results in a retry. Our application tracks this information for performance metrics purposes.
To implement such a change, it seems
NetworkingEngine
would need to accept aPlayerInterface
, but I don't know how that would work with alternative use cases as in #1297. Perhaps thePlayerInterface
could be optional, andNetworkingEngine
could do:Is this feasible?
The text was updated successfully, but these errors were encountered: