Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build pipeline #181

Closed
molszanski opened this issue Sep 11, 2015 · 3 comments
Closed

Docker build pipeline #181

molszanski opened this issue Sep 11, 2015 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug

Comments

@molszanski
Copy link

Since shaka requires specific java versions for build and run, and an end user may not have a proper version, the build will fail.

Moving a build process to docker will solve the issue once and for all and will provide a consistent build between all dev teams.

@tdrews tdrews added the type: enhancement New feature or request label Sep 11, 2015
@joeyparrish joeyparrish added status: working as intended The behavior is intended; this is not a bug and removed type: enhancement New feature or request labels Sep 11, 2015
@joeyparrish joeyparrish self-assigned this Sep 11, 2015
@joeyparrish
Copy link
Member

If you want to build from source, you will need Java to run the compiler. Java is only required to compile the sources, but not to run them.

If you want to run an uncompiled version from github, you only need Python to run ./build/gendeps.sh.

If you want a pre-built binary, we supply those via npm and cdnjs.

@molszanski
Copy link
Author

I know. Docker could liberate people who want to run the compiler/build but have an incompatible java stack.

@joeyparrish
Copy link
Member

Thanks for your suggestion. We'll keep it in mind, and may reconsider in future if there is demand for it.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug
Projects
None yet
Development

No branches or pull requests

5 participants