Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: A11y: ChromeVox triggers error callback in demo app #1862

Closed
joeyparrish opened this issue Apr 3, 2019 · 1 comment
Closed

UI: A11y: ChromeVox triggers error callback in demo app #1862

joeyparrish opened this issue Apr 3, 2019 · 1 comment
Assignees
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master

Can you reproduce the issue with our latest release version?
N/A: no UI in v2.4.x

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
demo

What browser and OS are you using?
ChromeOS

What are the manifest and license server URIs?
N/A

What did you do?
Activate ChromeVox screen reader by pressing Ctrl-Alt-Z

What did you expect to happen?
No errors

What actually happened?
Although ChromeVox activates and works, somehow, one of our error handlers is triggered and we display the error "goog.require could not find: cvox.ApiImplementation" in the demo app.

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI labels Apr 3, 2019
@shaka-bot shaka-bot added this to the v2.5 milestone Apr 3, 2019
@joeyparrish
Copy link
Member Author

This handler is being triggered:

  // Display uncaught exceptions.
  window.addEventListener('error', function(event) {
    shakaDemo.onError_(/** @type {!shaka.util.Error} */ (event.error));
  });

@joeyparrish joeyparrish self-assigned this Apr 10, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Jun 9, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants