Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Captions status inconsistent after reloading #1879

Closed
michellezhuogg opened this issue Apr 10, 2019 · 4 comments
Closed

Captions status inconsistent after reloading #1879

michellezhuogg opened this issue Apr 10, 2019 · 4 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.5

Comments

@michellezhuogg
Copy link
Contributor

  1. Load the demo app with Angel One. Turn on the English Captions.
  2. Hit 'Load' button again.
    The captions menu shows that 'English' is selected, however English captions is not being displayed.
@joeyparrish
Copy link
Member

The text container appears to be at z-index -1, while the controls and video are both at z-index 0. So the text is not only behind the controls, but the video. I think this is a duplicate of #1878.

@joeyparrish joeyparrish added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed needs triage labels Apr 10, 2019
@avelad
Copy link
Collaborator

avelad commented Apr 11, 2019

I see the same issue

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed status: duplicate A duplicate of another issue; should be closed after linking to the original issue labels Apr 11, 2019
@joeyparrish
Copy link
Member

I stand corrected. Separate issue.

@shaka-bot shaka-bot added this to the v2.5 milestone Apr 11, 2019
@TheModMaker
Copy link
Contributor

This also happens if you set the Preferred audio language to a different value than Preferred text language. The UI says captions are enabled but none show. I also get an assertion failure saying text visibility has fallen out of sync.

@TheModMaker TheModMaker self-assigned this Apr 24, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Jul 2, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
5 participants
@TheModMaker @joeyparrish @avelad @shaka-bot @michellezhuogg