Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTML Subtitles not working without the UI Library #2182

Closed
damjtoh opened this issue Oct 10, 2019 · 6 comments
Closed

TTML Subtitles not working without the UI Library #2182

damjtoh opened this issue Oct 10, 2019 · 6 comments
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug type: question A question from the community

Comments

@damjtoh
Copy link

damjtoh commented Oct 10, 2019

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5.5

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Custom app.

If custom app, can you reproduce the issue using our demo app?
No, but I tried building a custom app with the UI library and it works as expected.

What browser and OS are you using?
Ubuntu, Chrome v77

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What did you do?

I followed the basic usage tutorial. But we are not looking to use the UI Library.

What did you expect to happen?
TTML subtitles to work without the UI Library.

What actually happened?

The subtitles doesn't show up instead it shows a little black box as showed in the image.
New Project (4)

@avelad
Copy link
Collaborator

avelad commented Oct 11, 2019

Are you using SMPTE-TT or image format?

@damjtoh
Copy link
Author

damjtoh commented Oct 15, 2019

Hey @avelad, sorry for the late response, we are using image format.

@joeyparrish
Copy link
Member

If you're using images in your subtitles, the browser's native text display can't support that.

@joeyparrish joeyparrish added component: UI The issue involves the Shaka Player UI status: working as intended The behavior is intended; this is not a bug and removed needs triage labels Oct 15, 2019
@joeyparrish
Copy link
Member

If you'd like to use images in your subtitles without using the UI library, you can create your own implementation of the TextDisplayer interface. You can use our two implementations as examples, or you can fork the one from the UI and integrate it into your application without the rest of the UI library.

@joeyparrish joeyparrish added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 15, 2019
@damjtoh
Copy link
Author

damjtoh commented Oct 16, 2019

I forked the UI textDisplayer class and it worked like a charm! Thanks for the quick response.

@damjtoh damjtoh closed this as completed Oct 16, 2019
@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 16, 2019
@joeyparrish
Copy link
Member

Happy to help!

@shaka-project shaka-project locked and limited conversation to collaborators Dec 15, 2019
@joeyparrish joeyparrish added the type: question A question from the community label Feb 27, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI status: archived Archived and locked; will not be updated status: working as intended The behavior is intended; this is not a bug type: question A question from the community
Projects
None yet
Development

No branches or pull requests

4 participants