Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variants that can be played are being removed when useMediaCapabilties=true #3334

Closed
caridley opened this issue Apr 15, 2021 · 4 comments
Closed
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@caridley
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
master branch commit 4c97562

Can you reproduce the issue with our latest release version?
no problem does not occur with 2.5.20 or 3.0.10

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?
no - not sure how to run demo app with master branch code

What browser and OS are you using?
problem was observed on chrome with a mac and on a 2017 Tizen TV

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
https://dluxvod.spectrum.com/DASH_DRM/XPMV0001609509701001/out.ism/manifest.mpd
https://pi-lite.spectrum.net/licenseServer/widevine/v1/twc/license

Note that license request will fail, but the problem can be detected before the license request occurs.

What configuration are you using? What is the output of player.getConfiguration()?
see player-config.json in the attached shakaMissingVariants7LQN.zip file

What did you do?
Play the asset with useMediaCapabilties=true in player config

What did you expect to happen?
All 5 variants can be used

What actually happened?
Only the 2 lowest bitrate variants can be used

With shaka source code and the debugger I determined that the other variants were being removed by this function shaka.util.StreamUtils.filterManifestByDrm()

When useMediaCapabilties=false the problem does not occure.

config, manifest and log can be found in that attached file shakaMissingVariants7LQN.zip

@caridley
Copy link
Contributor Author

@michellezhuogg
Copy link
Contributor

Hello @caridley , thank you for reporting that!
The link of the license server URI looks invalid with our demo app. Would you please confirm that's available for testing? Thank you!

@caridley
Copy link
Contributor Author

@michellezhuogg I don't have an account that I can share with access to that stream at this time, but I think you will find that you can observe the problem without a valid license URL, by setting a break point in shaka.util.StreamUtils.filterManifestByDrm() where the variants are being removed prior to making any license request.

@michellezhuogg
Copy link
Contributor

@caridley Thank you! I verified that, and will work on improving that.

@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Apr 15, 2021
@shaka-bot shaka-bot added this to the v3.1 milestone Apr 16, 2021
@joeyparrish joeyparrish added the priority: P1 Big impact or workaround impractical; resolve before feature release label Apr 19, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 19, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants