Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking engine does not provide response HTTP status code #3640

Closed
Pavelas opened this issue Sep 16, 2021 · 1 comment
Closed

Networking engine does not provide response HTTP status code #3640

Pavelas opened this issue Sep 16, 2021 · 1 comment
Assignees
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@Pavelas
Copy link
Contributor

Pavelas commented Sep 16, 2021

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.2.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Irrelevant

If custom app, can you reproduce the issue using our demo app?
Irrelevant

What browser and OS are you using?
Irrelevant

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Irrelevant

What are the manifest and license server URIs?
Irrelevant

What configuration are you using? What is the output of player.getConfiguration()?
Irrelevant

What did you do?
I was trying to implement "License Wrapping", based on the official tutorial, as the result I had the following code:

player.getNetworkingEngine().registerResponseFilter(function (type, response) {
  if (!type == shaka.net.NetworkingEngine.RequestType.LICENSE) return;

  if (response.status === 200) ...One scenario

  if (response.status === 201) ...Another scenario
});

Unfortunately, my code did not work and it took some time in order to find out the reason. It seems that Networking Engine does not provide Response Status which is weird, because it provides almost all the information.

What did you expect to happen?
I was expecting that response will include response.status.

What actually happened?
As I mentioned before, my License Wrapping implementation did not work, because I was not able to compare response.status. I don't know the reason why it was excluded from response object.

@theodab theodab added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: enhancement New feature or request priority: P3 Useful but not urgent flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue and removed needs triage labels Sep 16, 2021
@theodab
Copy link
Collaborator

theodab commented Sep 16, 2021

Yeah, that sounds like a reasonable thing to add to me.

@shaka-bot shaka-bot added this to the Backlog milestone Sep 16, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 15, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Nov 15, 2021
@avelad avelad modified the milestones: Backlog, v4.0, v3.3 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants