Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Click play-pause ui configuration #3821

Closed
byungjuJin opened this issue Dec 23, 2021 · 0 comments
Closed

Single Click play-pause ui configuration #3821

byungjuJin opened this issue Dec 23, 2021 · 0 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@byungjuJin
Copy link

Have you read the FAQ and checked for duplicate open issues?
yes

Is your feature request related to a problem? Please describe.

consider add "singleClickForPlayAndPause" config for ui

Describe the solution you'd like

Now, When I do single-click, video play or pause.
I would like to user can not stop or seek watching video.
So I set

- remove play_pause button from "controlPanelElements"
- addSeekBar : false
- enableKeyboardPlaybackControls : false

but still user can pause with single click.

Describe alternatives you've considered

I added this but something silly. is it still ok?
video.addEventListener('pause', () => {video.play();}});

Additional context

Thanks for making a great player!

@byungjuJin byungjuJin added the type: enhancement New feature or request label Dec 23, 2021
@shaka-bot shaka-bot added this to the Backlog milestone Dec 23, 2021
@theodab theodab added component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Jan 4, 2022
@theodab theodab self-assigned this Jan 5, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
@avelad avelad modified the milestones: Backlog, v4.0, v3.3 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants