Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cast): Add Android receiver support #4183

Merged
merged 1 commit into from May 5, 2022
Merged

feat(cast): Add Android receiver support #4183

merged 1 commit into from May 5, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented May 3, 2022

Closes #3773
Closes #3772

@avelad avelad added type: enhancement New feature or request platform: Cast Issues affecting Cast devices labels May 3, 2022
@avelad avelad requested a review from joeyparrish May 3, 2022 10:20
@avelad avelad mentioned this pull request May 3, 2022
Closed
11 tasks
joeyparrish
joeyparrish requested changes May 3, 2022
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor requests for inline docs

lib/cast/cast_sender.js Outdated Show resolved Hide resolved
test/cast/cast_sender_unit.js Outdated Show resolved Hide resolved
test/cast/cast_sender_unit.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish May 3, 2022 17:35
@avelad
Copy link
Collaborator Author

avelad commented May 5, 2022 •
edited

@joeyparrish can you review it? Thanks!

@joeyparrish joeyparrish merged commit dbba571 into shaka-project:main May 5, 2022
@github-actions github-actions bot mentioned this pull request May 5, 2022
Closed
@avelad avelad deleted the cast-android-receiver branch May 6, 2022 06:21
@github-actions github-actions bot mentioned this pull request May 17, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chromecast] androidReceiverCompatible not supported
2 participants
@avelad @joeyparrish