Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right clicking video produces varying context menus. #422

Closed
tdrews opened this issue Jun 27, 2016 · 1 comment
Closed

Right clicking video produces varying context menus. #422

tdrews opened this issue Jun 27, 2016 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated

Comments

@tdrews
Copy link
Contributor

tdrews commented Jun 27, 2016

Sometimes right clicking on the video produces one context menu, showing "Loop, Show controls, ...", and other times it produces another, showing "Back, Forward, ...".

Expected: only the "Loop, Show controls, ..." context menu is shown.

Mirrored from http://crbug.com/609879

@tdrews tdrews changed the title Right click produces varying context menus. Right clicking video produces varying context menus. Jun 27, 2016
@joeyparrish
Copy link
Member

When the context menu shows "Back, Forward", selecting "Inspect" reveals the cause: the cursor is on element ID giantPlayButtonContainer instead of video.

The actual button (ID giantPlayButton) has the style display: none, but its container has display: block, which is why the container is receiving those clicks. We should be able to fix it by hiding the container.

@joeyparrish joeyparrish self-assigned this Jun 29, 2016
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

3 participants