fix: Don't send drmsessionupdate after unload #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an async call, waiting for sessions to update, right before the StreamingEngine fires off an drmsessionupdate event. This could potentially cause an error, as the StreamingEngine's player interface could potentially be set to null during destruction. This adds a check to see if the StreamingEngine has been destroyed, to catch that case. Based on a test failure of shaka-project#4241
avelad
approved these changes
May 20, 2022
|
I checked in local and I don't see any error. |
joeyparrish
pushed a commit
that referenced
this pull request
Jun 2, 2022
There is an async call, waiting for sessions to update, right before the StreamingEngine fires off an drmsessionupdate event. This could potentially cause an error, as the StreamingEngine's player interface could potentially be set to null during destruction. This adds a check to see if the StreamingEngine has been destroyed, to catch that case. Based on a test failure of #4241
joeyparrish
pushed a commit
that referenced
this pull request
Jun 2, 2022
There is an async call, waiting for sessions to update, right before the StreamingEngine fires off an drmsessionupdate event. This could potentially cause an error, as the StreamingEngine's player interface could potentially be set to null during destruction. This adds a check to see if the StreamingEngine has been destroyed, to catch that case. Based on a test failure of #4241
joeyparrish
pushed a commit
that referenced
this pull request
Jun 2, 2022
There is an async call, waiting for sessions to update, right before the StreamingEngine fires off an drmsessionupdate event. This could potentially cause an error, as the StreamingEngine's player interface could potentially be set to null during destruction. This adds a check to see if the StreamingEngine has been destroyed, to catch that case. Based on a test failure of #4241
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an async call, waiting for sessions to update, right before
the StreamingEngine fires off an drmsessionupdate event.
This could potentially cause an error, as the StreamingEngine's
player interface could potentially be set to null during destruction.
This adds a check to see if the StreamingEngine has been destroyed,
to catch that case.
Based on a test failure of #4241