fix(HLS): Fix duplicate hinted segments #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because zero-duration references cause such chaos, ensure that the HLS parser never produces these. Preload-hinted segments should use the target duration for partial segments, and if that required attribute is missing from the playlist, then preload-hinted segments should be skipped.
theodab
approved these changes
May 26, 2022
| // If DURATION is missing from this partial segment, use the target | ||
| // partial duration from the top of the playlist, which is a required | ||
| // attribute for content with partial segments. | ||
| const pDuration = Number(item.getAttributeValue('DURATION')) || |
There was a problem hiding this comment.
Technically this approach means that if a manifest has a tag with DURATION=0, we will ignore that. But I don't know why someone would want to do that, so it's probably fine to not account for it.
avelad
added
type: bug
|
@theodab Is it ready to merge? |
|
I had some disagreement with the original reporter of the issue via email, but I still believe this is the correct fix, and an important one based on the severity of the issue. I've informed them via email that we're going ahead with this fix. |
joeyparrish
added a commit
that referenced
this pull request
Jun 2, 2022
Because zero-duration references cause such chaos, ensure that the HLS parser never produces these. Preload-hinted segments should use the target duration for partial segments, and if that required attribute is missing from the playlist, then preload-hinted segments should be skipped. Closes #4223
joeyparrish
added a commit
that referenced
this pull request
Jun 2, 2022
Because zero-duration references cause such chaos, ensure that the HLS parser never produces these. Preload-hinted segments should use the target duration for partial segments, and if that required attribute is missing from the playlist, then preload-hinted segments should be skipped. Closes #4223
joeyparrish
added a commit
that referenced
this pull request
Jun 2, 2022
Because zero-duration references cause such chaos, ensure that the HLS parser never produces these. Preload-hinted segments should use the target duration for partial segments, and if that required attribute is missing from the playlist, then preload-hinted segments should be skipped. Closes #4223
theodab
pushed a commit
to theodab/shaka-player
that referenced
this pull request
Jun 3, 2022
Because zero-duration references cause such chaos, ensure that the HLS parser never produces these. Preload-hinted segments should use the target duration for partial segments, and if that required attribute is missing from the playlist, then preload-hinted segments should be skipped. Closes shaka-project#4223
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because zero-duration references cause such chaos, ensure that the HLS
parser never produces these. Preload-hinted segments should use the
target duration for partial segments, and if that required attribute
is missing from the playlist, then preload-hinted segments should be
skipped.
Closes #4223