feat: Caching and other efficiency improvements for mcap polyfill #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-nicholas
changed the title
|
Incremental code coverage: 100.00% |
avelad
added
type: enhancement
joeyparrish
requested changes
Nov 14, 2022
|
@dave-nicholas there are errors in the tests |
Fixed 👍 |
joeyparrish
requested changes
Nov 17, 2022
avelad
requested changes
Nov 18, 2022
avelad
approved these changes
Nov 18, 2022
joeyparrish
approved these changes
Nov 18, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the result of
requestMediaKeySystemAccesssaving time on subsequent calls.It also makes the calls to
decodingInfosynchronous. The reason for this, is the result of testing on multiple devices that the behaviour ofrequestMediaKeySystemAccessappears to be synchronous, making this synchronous can save over a second on older TVs.The issue is currently assigned to my colleague Hugo Lima.
Closes #4574