Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add preferredAudioLabel to PlayerConfiguration #4763

Merged
merged 2 commits into from Nov 29, 2022
Merged

feat: Add preferredAudioLabel to PlayerConfiguration #4763

merged 2 commits into from Nov 29, 2022

Conversation

tyrelltle
Copy link
Contributor

@tyrelltle tyrelltle commented Nov 28, 2022 •
edited by avelad

Closes #4762.

The change is to add PreferredAudioLabel to player configuration so that host apps can decide the default variant label to choose at very beginning.

@tyrelltle tyrelltle mentioned this pull request Nov 28, 2022
Closed
@avelad avelad changed the title Add preferredAudioLabel to PlayerConfiguration feat: Add preferredAudioLabel to PlayerConfiguration Nov 28, 2022
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Nov 28, 2022
@avelad avelad added this to the v4.4 milestone Nov 28, 2022
avelad
avelad requested changes Nov 28, 2022
View reviewed changes
AUTHORS Outdated Show resolved Hide resolved
CONTRIBUTORS Outdated Show resolved Hide resolved
demo/config.js Outdated Show resolved Hide resolved
@avelad
Copy link
Collaborator

avelad commented Nov 28, 2022

Please, fix the lint errors. Thanks!

@tyrelltle
Copy link
Contributor Author

tyrelltle commented Nov 28, 2022 •
edited

@avelad
Thanks for the comments I have updated accordingly.
(cc @joeyparrish sorry I accidentally removed review request for you and unable to add back)

One question:
Its added to v4.4, does it mean the change will not be added to current v4.2.x and v4.3.x ?

  • If yes, when is the v4.4 release?
  • Is there any criteria to make a PR to be eligible for getting cherry picked into current release (4.2.x and 4.3.x) ?

Thanks.

@tyrelltle tyrelltle requested review from avelad and removed request for joeyparrish November 28, 2022 22:47
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad requested a review from theodab November 29, 2022 07:05
@avelad avelad merged commit aadecd6 into shaka-project:main Nov 29, 2022
@github-actions github-actions bot mentioned this pull request Nov 29, 2022
Merged
@lindsayrr lindsayrr mentioned this pull request Dec 12, 2022
Closed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Add PreferredAudioLabel Configuration
3 participants
@tyrelltle @avelad @theodab