fix(HLS): support discontinuities in segments mode #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Mar 20, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where discontinuities in segments mode overwrite the existing content. This is due to the internal timestamps of segments in different discontinuity sequences overlapping (the first segment in each discontinuity sequence has an internal timestamp starting at 0). To solve this, this PR tracks the start time of each discontinuity sequence as the segment reference's
timestampOffset, and then adds logic to resync the sourcebuffer'stimestampOffsetto match these values.