Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow generate segments with Mp4Generator #5185

Merged
merged 3 commits into from Apr 28, 2023
Merged

feat: Allow generate segments with Mp4Generator #5185

merged 3 commits into from Apr 28, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 26, 2023 •
edited

This is part of the work to have our own transmuxers

@avelad avelad added the type: enhancement New feature or request label Apr 26, 2023
@avelad avelad added this to the v4.4 milestone Apr 26, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 45.00%

theodab
theodab requested changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code itself looks fine to me. I only have some minor issues with the nullability of the JSDoc.

lib/util/mp4_generator.js Outdated Show resolved Hide resolved
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
lib/util/mp4_generator.js Show resolved Hide resolved
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 27, 2023 14:12
@avelad avelad merged commit 8da971f into shaka-project:main Apr 28, 2023
16 checks passed
@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Merged
@avelad avelad deleted the mp4-segment-generator branch April 28, 2023 05:22
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avelad @theodab