Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast API to force-disconnect #523

Closed
avelad opened this issue Sep 16, 2016 · 1 comment
Closed

Chromecast API to force-disconnect #523

avelad opened this issue Sep 16, 2016 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@avelad
Copy link
Collaborator

avelad commented Sep 16, 2016

  • What version of Shaka Player are you using? 2.0.0
    • Can you reproduce the issue with our latest release version? Yes
    • Can you reproduce the issue with the latest code from master? Yes
  • Are you using the demo app or your own custom app? own custom app
    • If custom app, can you reproduce the issue using our demo app? It's not verifiable because has not shakaDemo.castProxy_.destroy()
  • What did you do? Start to reproduce any video, and cast the video. Call to shakaDemo.castProxy_.destroy()
  • What did you expect to happen? Chromecast session should be destroyed
  • What actually happened? Chromecast session remains open
@joeyparrish joeyparrish self-assigned this Sep 16, 2016
@joeyparrish
Copy link
Member

Destroying the proxy does not destroy the remote session because you might wish to leave it open. Many cast apps allow the sender to be shut down while allowing the receiver to continue running.

However, it appears we don't have a method on CastProxy to force the receiver to shut down. We can definitely add that.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Sep 16, 2016
@joeyparrish joeyparrish changed the title Chromecast isn't disconnected after destroy castProxy Chromecast API to force-disconnect Oct 4, 2016
@joeyparrish joeyparrish added this to the v2.1.0 milestone Oct 4, 2016
@joeyparrish joeyparrish removed their assignment Oct 4, 2016
@joeyparrish joeyparrish self-assigned this Oct 18, 2016
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants