Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AC3 transmuxer #5297

Merged
merged 6 commits into from Jun 24, 2023
Merged

feat: Add AC3 transmuxer #5297

merged 6 commits into from Jun 24, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 13, 2023

No description provided.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking labels Jun 13, 2023
@avelad avelad added this to the v4.4 milestone Jun 13, 2023
@avelad
Copy link
Collaborator Author

avelad commented Jun 13, 2023

For now it only includes the structure and the test, but I have opened the PR so that the community can see the progress.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2023

Incremental code coverage: 37.41%

@avelad avelad marked this pull request as ready for review June 21, 2023 08:44
@avelad
Copy link
Collaborator Author

avelad commented Jun 21, 2023

It seems that AC3 on Edge Windows from github actions is not working (in the lab AC3 is working), I think this chromium change is necessary: https://bugs.chromium.org/p/chromium/issues/detail?id=1450313 https://chromium-review.googlesource.com/c/chromium/src/+/4579038

@joeyparrish
Copy link
Member

It seems that AC3 on Edge Windows from github actions is not working (in the lab AC3 is working), I think this chromium change is necessary: https://bugs.chromium.org/p/chromium/issues/detail?id=1450313 https://chromium-review.googlesource.com/c/chromium/src/+/4579038

If I'm reading that correctly, detection is currently hard-coded to true, which leads to a failure in GitHub's environment. Is that correct?

For now, we could add a check in the test that excludes the current version of Edge (maybe both stable and beta). Future versions of Edge would run the test automatically. What do you think?

@avelad
Copy link
Collaborator Author

avelad commented Jun 22, 2023

It seems that AC3 on Edge Windows from github actions is not working (in the lab AC3 is working), I think this chromium change is necessary: https://bugs.chromium.org/p/chromium/issues/detail?id=1450313 https://chromium-review.googlesource.com/c/chromium/src/+/4579038

If I'm reading that correctly, detection is currently hard-coded to true, which leads to a failure in GitHub's environment. Is that correct?

Yes, it's correct.

For now, we could add a check in the test that excludes the current version of Edge (maybe both stable and beta). Future versions of Edge would run the test automatically. What do you think?

I'll do it

lib/transmuxer/ac3.js Outdated Show resolved Hide resolved
lib/transmuxer/ac3.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 23, 2023 11:27
@avelad avelad merged commit 6f83997 into shaka-project:main Jun 24, 2023
28 of 30 checks passed
@avelad avelad deleted the ac3-transmuxer branch June 25, 2023 15:29
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants