feat: Abr improvement config #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Demo to expose the parameter Update the documentation Add the default value of the parameter to don’t change Shaka standard behaviour Update Simple ABR manager to use the parameter
|
I'm not sure to understand why this test failed. The drm test player and the other one. Could it be link to other issue? |
|
Our integration tests sometimes flake. It probably doesn't have anything to do with your PR. |
|
@theodab thanks for your feedback. Let me know you you have any questions about the pr. |
|
Incremental code coverage: 50.00% |
|
@theodab any update on this pr ? |
avelad
added
type: enhancement
avelad
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose an improvement of the AbrConfiguration with this 2 new parameter (as optional) and a new version of the SimpleAbrManager using that parameter for the switch this.switch_(chosenVariant /* , clearbuffer, safe margin*/);
Also providing information about the parameter and updated the demo app with the capabilities to modify it.
Corrected the unit test and added specific unit test for it