Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Allow multiple calls to requestAds in CS #5542

Merged
merged 1 commit into from Aug 28, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 28, 2023

No description provided.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Aug 28, 2023
@avelad avelad added this to the v4.4 milestone Aug 28, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad changed the title feat(Ads): Allow multiple calls to requestAds in CC feat(Ads): Allow multiple calls to requestAds in CS Aug 28, 2023
@joeyparrish joeyparrish merged commit 837e0fb into shaka-project:main Aug 28, 2023
21 of 22 checks passed
@avelad avelad deleted the multiple-requestAds branch August 29, 2023 06:46
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 27, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants