Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Orange set top box is incorrectly categorized as Apple #5545

Merged
merged 47 commits into from Aug 28, 2023

Conversation

willdharris
Copy link
Contributor

This PR adds an Orange platform check and excludes Orange from the isApple() check.

Resolves: #5544

dsparacio and others added 30 commits October 29, 2020 16:06
@avelad avelad added type: bug Something isn't working correctly platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P2 Smaller impact or easy workaround labels Aug 28, 2023
@avelad avelad added this to the v4.4 milestone Aug 28, 2023
@avelad avelad requested a review from littlespex August 28, 2023 16:38
@joeyparrish joeyparrish merged commit 937484e into shaka-project:main Aug 28, 2023
21 of 22 checks passed
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
This PR adds an Orange platform check and excludes Orange from the
isApple() check.

Resolves: #5544

---------

Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com>
Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
This PR adds an Orange platform check and excludes Orange from the
isApple() check.

Resolves: #5544

---------

Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com>
Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 27, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Paramount] - Video Start Failure on Orange Set Top Box
6 participants