Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Mp4Generator #5566

Merged
merged 1 commit into from Aug 31, 2023
Merged

fix: Fix Mp4Generator #5566

merged 1 commit into from Aug 31, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Aug 31, 2023

Fixes the mvex generation
Removes width and height from tkhd box for audio tracks

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Aug 31, 2023
@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
Fixes the mvex generation
Removes width and height from tkhd box for audio tracks
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad merged commit effafbc into shaka-project:main Aug 31, 2023
28 of 31 checks passed
@avelad avelad deleted the fix-mp4-generator branch August 31, 2023 08:12
joeyparrish pushed a commit that referenced this pull request Sep 2, 2023
Fixes the mvex generation
Removes width and height from tkhd box for audio tracks
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 30, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants