Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CEA): Parse CEA from TS with H.265 #5610

Merged
merged 1 commit into from Sep 7, 2023
Merged

feat(CEA): Parse CEA from TS with H.265 #5610

merged 1 commit into from Sep 7, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 6, 2023

No description provided.

@avelad avelad added type: enhancement New feature or request component: captions/subtitles The issue involves captions or subtitles labels Sep 6, 2023
@avelad avelad added this to the v4.5 milestone Sep 6, 2023
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent labels Sep 6, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 79.59%

joeyparrish
joeyparrish reviewed Sep 6, 2023
View reviewed changes
lib/util/ts_parser.js
Comment on lines +711 to +713
if (this.videoCodec_ != 'avc') {
return videoInfo;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we unable to get video info from HEVC? Is that coming later in #5611?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can, but it will come in another PR, so we limit the scopes of the less important PRs and they are easier to review.

@joeyparrish joeyparrish changed the title feat(CEA): Allow parse CEA from TS with H.265 feat(CEA): Parse CEA from TS with H.265 Sep 6, 2023
@avelad avelad merged commit 54eaf63 into shaka-project:main Sep 7, 2023
23 checks passed
@avelad avelad deleted the cea-ts-h265 branch September 7, 2023 06:36
@shaka-bot shaka-bot mentioned this pull request Sep 7, 2023
Closed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 6, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @shaka-bot @joeyparrish