Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DASH): Add new config to prevent mixing of audio representations from different adaptation sets #5620

Merged
merged 2 commits into from Sep 13, 2023
Merged

feat(DASH): Add new config to prevent mixing of audio representations from different adaptation sets #5620

merged 2 commits into from Sep 13, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 8, 2023

Closes #5461

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Sep 8, 2023
@avelad avelad added this to the v4.5 milestone Sep 8, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Sep 8, 2023 •
edited

Incremental code coverage: 100.00%

joeyparrish
joeyparrish requested changes Sep 13, 2023
View reviewed changes
lib/media/adaptation_set.js Outdated Show resolved Hide resolved
lib/media/adaptation_set_criteria.js Outdated Show resolved Hide resolved
@avelad avelad merged commit 0bbb470 into shaka-project:main Sep 13, 2023
16 checks passed
@avelad avelad deleted the dash-audio-groups branch September 14, 2023 07:22
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 12, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

DASH - Prevent mixing of audio representations from different adaptation sets
3 participants
@avelad @shaka-bot @joeyparrish