revert: "fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)" #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#5641)" This reverts commit 56a4cea.
avelad
added
type: bug
avelad
requested review from
littlespex,
joeyparrish,
JulianDomingo and
theodab
|
Incremental code coverage: 100.00% |
avelad
changed the title
theodab
approved these changes
Sep 15, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 21, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 56a4cea.
Fixes #5661
BEGIN_COMMIT_OVERRIDE
fix(WebVTT): Fix text displayed out of picture and with overlapping lines (#5662)
This reverts commit 56a4cea, PR #5641
Fixes #5661
END_COMMIT_OVERRIDE