Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix creation of new Stream object for each manifest request in DASH Live when using CEA #5674

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: Fix creation of new Stream object for each manifest request in DASH Live when using CEA #5674

merged 1 commit into from
Sep 25, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 25, 2023

Fixes #5672

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 25, 2023
@avelad avelad added this to the v4.5 milestone Sep 25, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad avelad changed the title fix: Fix creation of new Stream objec for each manifest request in DASH Live when using CEA fix: Fix creation of new Stream object for each manifest request in DASH Live when using CEA Sep 25, 2023
@avelad avelad merged commit 0a8b519 into shaka-project:main Sep 25, 2023
21 of 22 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 25, 2023
Closed
@avelad avelad deleted the cea-dash branch September 25, 2023 09:59
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix: Fix creation of new Stream object for each manifest request in D…
fdc1e9f 
…ASH Live when using CEA (#5674)

Fixes #5672
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix: Fix creation of new Stream object for each manifest request in D…
d9223ee 
…ASH Live when using CEA (#5674)

Fixes #5672
This was referenced Sep 21, 2023
Merged
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

CEA-608 /708 Embedded captions in Dash livestream creating new text Stream object for each manifest request.
3 participants
@avelad @shaka-bot @theodab