Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix transmuxing of muxed content #5686

Merged
merged 1 commit into from Sep 27, 2023
Merged

fix: Fix transmuxing of muxed content #5686

merged 1 commit into from Sep 27, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 27, 2023 •
edited

Fixes #5684

This PR fixes two issues:

  • Fixes the duration of a video sample when there is only one pes packet.
  • When there is muxed content, in some TS segments there is not audio but the audio is declared in the PMT, so we have to add silence frames

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 27, 2023
@avelad avelad added this to the v4.5 milestone Sep 27, 2023
@avelad avelad mentioned this pull request Sep 27, 2023
Closed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 18.46%

@avelad avelad merged commit f20d50a into shaka-project:main Sep 27, 2023
22 checks passed
@avelad avelad deleted the silence-frames branch September 27, 2023 09:17
@shaka-bot shaka-bot mentioned this pull request Sep 27, 2023
Closed
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 26, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

Need a better way to detect whether mux.js has finished transcoding or not
3 participants
@avelad @shaka-bot @theodab