Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix display CEA-708 in HLS #5694

Merged
merged 1 commit into from Sep 29, 2023
Merged

fix(HLS): Fix display CEA-708 in HLS #5694

merged 1 commit into from Sep 29, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Sep 29, 2023

Fixes #5627

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 29, 2023
@avelad avelad added this to the v4.5 milestone Sep 29, 2023
@avelad avelad mentioned this pull request Sep 29, 2023
Closed
@avelad avelad merged commit 2097193 into shaka-project:main Sep 29, 2023
22 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 29, 2023
Closed
@avelad avelad deleted the cea-708-hls branch September 29, 2023 09:31
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 60.00%

joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Fix display CEA-708 in HLS (#5694)
3c068ea 
Fixes #5627
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Fix display CEA-708 in HLS (#5694)
b639b55 
Fixes #5627

Backported to v4.3.x
@shaka-bot shaka-bot mentioned this pull request Sep 21, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Oct 4, 2023
@avelad @joeyparrish
fix(HLS): Fix display CEA-708 in HLS (#5694)
ed1d954 
Fixes #5627
@shaka-bot shaka-bot mentioned this pull request Oct 4, 2023
Merged
@shashikantkonded-git
Copy link

@avelad is there any possibility of merging this to 3.3.x branch?

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 28, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

Close captions (CEA 608/708) are not working in Live HLS playback.
4 participants
@avelad @shaka-bot @shashikantkonded-git @theodab