feat: Add KeyStatusChanged and UpdateState events #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
theodab
approved these changes
Sep 29, 2023
|
Incremental code coverage: No instrumented code was changed. |
|
Some tests fail but I think it is not because of this PR. @joeyparrish can you review it? (see: https://github.com/shaka-project/shaka-player/actions/runs/6350193501/attempts/6) |
joeyparrish
previously requested changes
Sep 29, 2023
lib/player.js
Outdated
| * @event shaka.Player.UpdateState | ||
| * @description Fired when player state is updated. | ||
| * @property {string} type | ||
| * 'updatestate' |
There was a problem hiding this comment.
It is more conventional to call a change event something like "statechanged", as you did for "keystatuschanged".
|
It is suspicious that Chrome & Edge both failed to start on every platform. It's certainly not caused by your changes. Probably something happened on GitHub's VM images or in Chrome's releases to trigger this. |
theodab
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1365