feat(DASH): Add support for Content Steering #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 94.05% |
avelad
force-pushed
the
content-steering
branch
9 times, most recently
from
5b27bbf
to
da0b312
Compare
avelad
force-pushed
the
content-steering
branch
from
da0b312
to
49bd656
Compare
# Conflicts: # test/dash/dash_parser_manifest_unit.js
# Conflicts: # lib/dash/dash_parser.js # lib/dash/segment_base.js # lib/dash/segment_list.js # lib/dash/segment_template.js # lib/hls/hls_parser.js
avelad
changed the title
avelad
force-pushed
the
content-steering
branch
from
0dad90d
to
b1af069
Compare
|
@theodab can you review it? Thanks! |
theodab
requested changes
Nov 8, 2023
| } | ||
| } | ||
| } | ||
| if (!someLocationValid || !this.contentSteeringManager_) { |
There was a problem hiding this comment.
Won't someLocationValid always be false when this.contentSteeringManager_ is null? I think the second half of this check is unnecessary.
There was a problem hiding this comment.
It is necessary because it may be the case that some manifests have incorrect information and the BaseURLs do not have any url with serviceLocation
theodab
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5704