fix: Fix unreleased stack overflow on statechanged #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not dispatch statechanged events unless there is an actual change. This fixes a stack overflow in the Cast proxy code triggered by statechanged events.
|
Fixing the bug was fast. Figuring out how to write a regression test that fails without the fix... that took significantly longer. 😁 |
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
avelad
approved these changes
Oct 3, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
Do not dispatch statechanged events unless there is an actual change. This fixes a stack overflow in the Cast proxy code triggered by statechanged events.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not dispatch statechanged events unless there is an actual change. This fixes a stack overflow in the Cast proxy code triggered by statechanged events.