Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: For text content is not necessary codec switching #5731

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: For text content is not necessary codec switching #5731

merged 1 commit into from
Oct 5, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 5, 2023

Fixes #5730

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Oct 5, 2023
@avelad avelad added this to the v4.6 milestone Oct 5, 2023
@avelad avelad linked an issue Oct 5, 2023 that may be closed by this pull request
Multi Period DASH with Subtitle does not work #5730
Closed
@avelad avelad mentioned this pull request Oct 5, 2023
Closed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 66.67%

@avelad avelad merged commit bdbaae5 into shaka-project:main Oct 5, 2023
19 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 5, 2023
Merged
@avelad avelad deleted the text-codec-change branch October 6, 2023 06:44
joeyparrish pushed a commit that referenced this pull request Oct 6, 2023
@avelad @joeyparrish
fix: For text content is not necessary codec switching (#5731)
f243586 
Fixes #5730
@shaka-bot shaka-bot mentioned this pull request Oct 6, 2023
Closed
@littlespex littlespex mentioned this pull request Oct 31, 2023
Closed
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix: For text content is not necessary codec switching (shaka-project…
be060b5 
…#5731)

Fixes shaka-project#5730
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 4, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Multi Period DASH with Subtitle does not work
3 participants
@avelad @shaka-bot @theodab