Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix text selector when the trackLabelFormat is set to LABEL #5751

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(UI): Fix text selector when the trackLabelFormat is set to LABEL #5751

merged 1 commit into from
Oct 9, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 9, 2023

Fixes #5747

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Oct 9, 2023
@avelad avelad added this to the v4.6 milestone Oct 9, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 72.73%

@avelad avelad merged commit bba0651 into shaka-project:main Oct 9, 2023
21 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 9, 2023
Merged
@avelad avelad deleted the ui-label-format branch October 9, 2023 09:10
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(UI): Fix text selector when the trackLabelFormat is set to LABEL (s…
6c45b16 
…haka-project#5751)

Fixes shaka-project#5747
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 8, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

UI: text track selector deduplicates by language and role when the trackLabelFormat is set to LABEL
3 participants
@avelad @shaka-bot @theodab