perf(dash): improve readability and reduce number of loops in dash parser #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
avelad
changed the title
avelad
added
type: performance
vanyaxk
force-pushed
the
refactor/improve-readability-in-dash-period-parser
branch
from
3de6bfd
to
685ec39
Compare
vanyaxk
force-pushed
the
refactor/improve-readability-in-dash-period-parser
branch
from
685ec39
to
9bd1040
Compare
theodab
requested changes
Oct 19, 2023
lib/dash/dash_parser.js
Outdated
| return []; | ||
| } | ||
|
|
||
| return adaptationSets.reduce((acc, currSet) => { |
There was a problem hiding this comment.
You could also use shaka.util.Functional.collapseArrays for this.
Something like...
return adaptationSets.map((set) => {
return set.contentType == contentType ? set.streams : [];
}).reduce(shaka.util.Functional.collapseArrays, []);If you think that doing it this way is better, though, instead I'll ask that you rename the variables on the method to all and part, as that is what we usually call them when reducing arrays.
There was a problem hiding this comment.
changed to (all, part)
theodab
approved these changes
Oct 20, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…rser (shaka-project#5768) This change reduces the amount of loops in dash parser, and improves code readability, as checking config and creating an array of sets is in a separate method now. --------- Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the amount of loops in dash parser, and improves code readability, as checking config and creating an array of sets is in a separate method now.