perf(manifest): avoid unnecessary looping in uri resolver #5773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
|
Can you fix the errors? Thanks! |
avelad
added
type: performance
vanyaxk
force-pushed
the
refactor/avoid-unnecessary-looping-in-manifest-parser
branch
from
12d90f0
to
71a4987
Compare
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Oct 17, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…ect#5773) This removes creating an array of arrays in manifest URI resolver and uses a nested loop to update an empty array instead Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes creating an array of arrays in manifest URI resolver and uses a nested loop to update an empty array instead