perf(DASH): reduce looping and remove chaining awaits in period #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
type: performance
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Oct 18, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…a-project#5774) This change removes chaining awaits in period combiner when combining variants and parses streams in one loop instead of 4 Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
gkatsev
pushed a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Dec 6, 2023
* feat: Improve performance of multi-period DASH parsing (shaka-project#5350) For manifests with many streams, we saw the bulk of the manifest parse time going towards period combiner. Specifically: splitting codecs and comparing DRMs. This change cuts our manifest parse time for large manifests by nearly 30%. There are two changes: 1. Memoize the normalized codecs inside the period combiner. 2. Short circuit the DRM compatibility check if the DRMInfos arrays are the same object. We run a custom manifest parser and are therefore able to re-use the same drm infos array for functionally equivalent drms, but short circuiting also helps since in the case that the upstream period combiner is comparing a candidate stream with itself. * perf(DASH): reduce looping and remove chaining awaits in period (shaka-project#5774) This change removes chaining awaits in period combiner when combining variants and parses streams in one loop instead of 4 Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar> * perf(DASH): PeriodCombiner optimisations (shaka-project#5837) - reduce number of iterations during filtering out stream duplicates - reduce number of iterations when extending output stream - for audio or video only content, reuse existing stream array instead of copying it * some low hanging fruits optimized * match optimization by looking for duplicates * use stream once * add hash map and config * concat arrays * use slice() instead of Array.from() to clone * remove manifest.filterOutStreamDuplicates As we're using Map for making unique keys already, we don't need to filter out duplicates anymore. * simplify generating key * alias for shaka.util.PeriodCombiner --------- Co-authored-by: baconz <baconz@users.noreply.github.com> Co-authored-by: Ivan <48260572+vanyaxk@users.noreply.github.com> Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes chaining awaits in period combiner when combining variants and parses streams in one loop instead of 4