perf(Xbox): drop incompatible variants for XBOX early #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 83.33% |
avelad
changed the title
avelad
changed the title
avelad
added
type: performance
joeyparrish
requested changes
Oct 18, 2023
lib/util/stream_utils.js
Outdated
| // See: https://github.com/shaka-project/shaka-player/issues/3380 | ||
| // Note: it makes sense to drop early | ||
| if (isXboxOne && video && | ||
| ((video.width && video.width > 1920) || |
There was a problem hiding this comment.
If width is null or undefined, it will not be > 1920. Please drop the "truthy" checks on width and height and combine width > 1920 || height > 1080 on one line if possible, to make this long sequence of booleans more readable.
Also, these continuations should be indented +2 from where they are now. That will also make them easier to differentiate from the log inside the if(). Thanks!
There was a problem hiding this comment.
unfortunately, the compiler had a problem with that change, but I added dimension variables to make sure the type is right - hope that's OK
theodab
approved these changes
Oct 18, 2023
joeyparrish
requested changes
Oct 18, 2023
joeyparrish
approved these changes
Oct 18, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…5777) This change: - drops incompatible variants for XBOX before parsing codes and checking them against media capabilities API - avoids redeclaring variables each time in the loop Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: