feat(thumbnails): Add Player.getAllThumbnails #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returns every thumbnail for a given image track ID, simplifying the process of determining how many thumbnails a given image track contains. Closes shaka-project#5781
|
Incremental code coverage: 89.55% |
|
@theodab please, add an integration test. Thanks! (see: https://github.com/shaka-project/shaka-player/blob/main/test/player_integration.js#L1301) |
Done. |
avelad
approved these changes
Oct 19, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
This method returns every thumbnail for a given image track ID, simplifying the process of determining how many thumbnails a given image track contains. Closes shaka-project#5781
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method returns every thumbnail for a given image track ID, simplifying the process of determining how many thumbnails a given image track contains.
Closes #5781