Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a stub text display class (#5804) #5806

Merged
merged 1 commit into from Oct 26, 2023

Conversation

kaidokert
Copy link
Contributor

@kaidokert kaidokert commented Oct 24, 2023

Closes #5804

@kaidokert kaidokert changed the title Add a stub text display class (#5804) feat: Add a stub text display class (#5804) Oct 24, 2023
lib/player.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

shaka-bot commented Oct 24, 2023

Incremental code coverage: 89.19%

lib/player.js Outdated Show resolved Hide resolved
@avelad avelad added type: enhancement New feature or request priority: P4 Nice to have / wishful thinking labels Oct 25, 2023
@avelad avelad added this to the v4.6 milestone Oct 25, 2023
@avelad avelad merged commit 700d181 into shaka-project:main Oct 26, 2023
15 checks passed
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting Cobalt
4 participants