Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WebVTT): Fix wrong writing-mode in nested cues #5807

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(WebVTT): Fix wrong writing-mode in nested cues #5807

merged 1 commit into from
Oct 25, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 25, 2023

Fixes #4765

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Oct 25, 2023
@avelad avelad added this to the v4.6 milestone Oct 25, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit ea7d83e into shaka-project:main Oct 25, 2023
21 checks passed
@avelad avelad deleted the writing-mode-webvtt branch October 25, 2023 08:07
@shaka-bot shaka-bot mentioned this pull request Oct 25, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(WebVTT): Fix wrong writing-mode in nested cues (shaka-project#5807)
d8a5717 
Fixes shaka-project#4765
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

WebVTT wrong writing-mode in nested cues
3 participants
@avelad @shaka-bot @theodab