Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UITextDisplayer font-family is overridden by UI's Roboto font #5829

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix: UITextDisplayer font-family is overridden by UI's Roboto font #5829

merged 1 commit into from
Oct 30, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Oct 30, 2023

Fixes #5827

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Oct 30, 2023
@avelad avelad added this to the v4.6 milestone Oct 30, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad avelad merged commit cb8a5ed into shaka-project:main Oct 30, 2023
21 checks passed
@avelad avelad deleted the font-family branch October 30, 2023 15:24
@shaka-bot shaka-bot mentioned this pull request Oct 30, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix: UITextDisplayer font-family is overridden by UI's Roboto font (s…
bf0a5e9 
…haka-project#5829)

Fixes shaka-project#5827
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 29, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

UITextDisplayer font-family is overridden by UI's Roboto font
3 participants
@avelad @shaka-bot @littlespex