Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hisense): set stallSkip to 0 for HiSense devices #5833

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(hisense): set stallSkip to 0 for HiSense devices #5833

merged 1 commit into from
Oct 30, 2023

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Oct 30, 2023 •
edited

This change fixes an issue on HiSense devices, where playback is sometimes repeated because current time is updated by skip on devices which don't support precise seeking

@avelad avelad added this to the v4.6 milestone Oct 30, 2023
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Oct 30, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit c457db8 into shaka-project:main Oct 30, 2023
20 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Oct 30, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@vanyaxk
fix(hisense): set stallSkip to 0 for HiSense devices (shaka-project#5833
1be861c 
)

This change fixes an issue on HiSense devices, where playback is
sometimes repeated because current time is updated by skip on devices
which don't support precise seeking

Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 29, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@avelad avelad Awaiting requested review from avelad

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vanyaxk @shaka-bot @littlespex @avelad